Use IAction instead of Action for search item action
#164844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For actions that are static, it is better to use `IAction` instead of `Action`. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar). It also means you don't have to dispose of the action This small optimization is useful here because we create one of these actions for every search item in the list as you scroll
|
@andreamah I've only updated this one action since it was the most commonly rendered once. If you agree this is a worthwhile change, you can also apply this same change to the other actions At the very least, it means you don't have to dispose of the actions that you create, which is easy to forget to do |
andreamah
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For actions that are static, it is better to use
IActioninstead ofAction. This avoids creating an extra disposable, emitter, and event listener (when used with an action bar). It also means you don't have to dispose of the actionThis small optimization is useful here because we create one of these actions for every search item in the list as you scroll